Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 52ba5b87 authored by Wang Yufen's avatar Wang Yufen Committed by Greg Kroah-Hartman
Browse files

binfmt: Fix error return code in load_elf_fdpic_binary() 



[ Upstream commit e7f703ff2507f4e9f496da96cd4b78fd3026120c ]

Fix to return a negative error code from create_elf_fdpic_tables()
instead of 0.

Fixes: 1da177e4 ("Linux-2.6.12-rc2")
Cc: stable@vger.kernel.org
Signed-off-by: default avatarWang Yufen <wangyufen@huawei.com>
Signed-off-by: default avatarKees Cook <keescook@chromium.org>
Link: https://lore.kernel.org/r/1669945261-30271-1-git-send-email-wangyufen@huawei.com


Signed-off-by: default avatarSasha Levin <sashal@kernel.org>
parent 33933af4

fs/binfmt_elf_fdpic.c

+3 −2
Original line number Diff line number Diff line
@@ -435,8 +435,9 @@ static int load_elf_fdpic_binary(struct linux_binprm *bprm) 
	current->mm->start_stack = current->mm->start_brk + stack_size;

#endif



	if (create_elf_fdpic_tables(bprm, current->mm,

				    &exec_params, &interp_params) < 0)

	retval = create_elf_fdpic_tables(bprm, current->mm, &exec_params,

					 &interp_params);

	if (retval < 0)

		goto error;



	kdebug("- start_code  %lx", current->mm->start_code);