Commit 52441fa8 authored Jan 03, 2013 by Sasha Levin Committed by Rusty Russell Jan 03, 2013

module: prevent warning when finit_module a 0 sized file



If we try to finit_module on a file sized 0 bytes vmalloc will
scream and spit out a warning.

Since modules have to be bigger than 0 bytes anyways we can just
check that beforehand and avoid the warning.

Signed-off-by: Sasha Levin <sasha.levin@oracle.com>
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>

parent f4953fe6

kernel/module.c

+7 −0

Original line number	Original line	Diff line number	Diff line
	@@ -2527,6 +2527,13 @@ static int copy_module_from_fd(int fd, struct load_info *info)
	err = -EFBIG;		err = -EFBIG;
	goto out;		goto out;
	}		}

			/* Don't hand 0 to vmalloc, it whines. */
			if (stat.size == 0) {
			err = -EINVAL;
			goto out;
			}

	info->hdr = vmalloc(stat.size);		info->hdr = vmalloc(stat.size);
	if (!info->hdr) {		if (!info->hdr) {
	err = -ENOMEM;		err = -ENOMEM;