Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 523fc5c1 authored by Tomoki Sekiyama's avatar Tomoki Sekiyama Committed by Greg Kroah-Hartman
Browse files

USB: yurex: Remove allocation of coherent buffer for setup-packet buffer 



Removes allocation of coherent buffer for the control-request setup-packet
buffer from the yurex driver. Using coherent buffers for setup-packet is
obsolete and does not work with some USB host implementations.

Signed-off-by: default avatarTomoki Sekiyama <tomoki.sekiyama@gmail.com>
Cc: stable <stable@vger.kernel.org>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent f4a728d0

drivers/usb/misc/yurex.c

+2 −6
Original line number Diff line number Diff line
@@ -99,9 +99,7 @@ static void yurex_delete(struct kref *kref) 
	usb_put_dev(dev->udev);

	if (dev->cntl_urb) {

		usb_kill_urb(dev->cntl_urb);

		if (dev->cntl_req)

			usb_free_coherent(dev->udev, YUREX_BUF_SIZE,

				dev->cntl_req, dev->cntl_urb->setup_dma);

		kfree(dev->cntl_req);

		if (dev->cntl_buffer)

			usb_free_coherent(dev->udev, YUREX_BUF_SIZE,

				dev->cntl_buffer, dev->cntl_urb->transfer_dma);
@@ -234,9 +232,7 @@ static int yurex_probe(struct usb_interface *interface, const struct usb_device_ 
	}



	/* allocate buffer for control req */

	dev->cntl_req = usb_alloc_coherent(dev->udev, YUREX_BUF_SIZE,

					   GFP_KERNEL,

					   &dev->cntl_urb->setup_dma);

	dev->cntl_req = kmalloc(YUREX_BUF_SIZE, GFP_KERNEL);

	if (!dev->cntl_req) {

		err("Could not allocate cntl_req");

		goto error;