Commit 52239484 authored Sep 05, 2013 by Libin Committed by Ingo Molnar Sep 05, 2013

x86/smpboot: Fix announce_cpu() to printk() the last "OK" properly



When booting secondary CPUs, announce_cpu() is called to show which cpu has
been brought up. For example:

[    0.402751] smpboot: Booting Node   0, Processors  #1 #2 #3 #4 #5 OK
[    0.525667] smpboot: Booting Node   1, Processors  #6 #7 #8 #9 #10 #11 OK
[    0.755592] smpboot: Booting Node   0, Processors  #12 #13 #14 #15 #16 #17 OK
[    0.890495] smpboot: Booting Node   1, Processors  #18 #19 #20 #21 #22 #23

But the last "OK" is lost, because 'nr_cpu_ids-1' represents the maximum
possible cpu id. It should use the maximum present cpu id in case not all
CPUs booted up.

Signed-off-by: Libin <huawei.libin@huawei.com>
Cc: <guohanjun@huawei.com>
Cc: <wangyijing@huawei.com>
Cc: <fenghua.yu@intel.com>
Cc: <paul.gortmaker@windriver.com>
Link: http://lkml.kernel.org/r/1378378676-18276-1-git-send-email-huawei.libin@huawei.com


[ tweaked the changelog, removed unnecessary line break, tweaked the format to align the fields vertically. ]
Signed-off-by: Ingo Molnar <mingo@kernel.org>

parent 4488e09b

arch/x86/kernel/smpboot.c

+2 −1

Original line number	Diff line number	Diff line
		@@ -653,6 +653,7 @@ static void announce_cpu(int cpu, int apicid)
		{
		static int current_node = -1;
		int node = early_cpu_to_node(cpu);
		int max_cpu_present = find_last_bit(cpumask_bits(cpu_present_mask), NR_CPUS);

		if (system_state == SYSTEM_BOOTING) {
		if (node != current_node) {
		@@ -661,7 +662,7 @@ static void announce_cpu(int cpu, int apicid)
		current_node = node;
		pr_info("Booting Node %3d, Processors ", node);
		}
		pr_cont(" #%d%s", cpu, cpu == (nr_cpu_ids - 1) ? " OK\n" : "");
		pr_cont(" #%4d%s", cpu, cpu == max_cpu_present ? " OK\n" : "");
		return;
		} else
		pr_info("Booting Node %d Processor %d APIC 0x%x\n",