Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 5217ae08 authored by Sakari Ailus's avatar Sakari Ailus Committed by Greg Kroah-Hartman
Browse files

ACPI: properties: Consistently return -ENOENT if there are no more references 



commit babc92da5928f81af951663fc436997352e02d3a upstream.

__acpi_node_get_property_reference() is documented to return -ENOENT if
the caller requests a property reference at an index that does not exist,
not -EINVAL which it actually does.

Fix this by returning -ENOENT consistenly, independently of whether the
property value is a plain reference or a package.

Fixes: c343bc2c ("ACPI: properties: Align return codes of __acpi_node_get_property_reference()")
Cc: 4.14+ <stable@vger.kernel.org> # 4.14+
Signed-off-by: default avatarSakari Ailus <sakari.ailus@linux.intel.com>
Signed-off-by: default avatarRafael J. Wysocki <rafael.j.wysocki@intel.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent f3ec0c9d

drivers/acpi/property.c

+1 −1
Original line number Diff line number Diff line
@@ -692,7 +692,7 @@ int __acpi_node_get_property_reference(const struct fwnode_handle *fwnode, 
	 */

	if (obj->type == ACPI_TYPE_LOCAL_REFERENCE) {

		if (index)

			return -EINVAL;

			return -ENOENT;



		ret = acpi_bus_get_device(obj->reference.handle, &device);

		if (ret)