Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 51e68fb0 authored by Takashi Sakamoto's avatar Takashi Sakamoto Committed by Takashi Iwai
Browse files

ALSA: isight: fix leak of reference to firewire unit in error path of .probe callback 



In some error paths, reference count of firewire unit is not decreased.
This commit fixes the bug.

Fixes: 5b14ec25('ALSA: firewire: release reference count of firewire unit in .remove callback of bus driver')
Signed-off-by: default avatarTakashi Sakamoto <o-takashi@sakamocchi.jp>
Signed-off-by: default avatarTakashi Iwai <tiwai@suse.de>
parent e7bb6ad5

sound/firewire/isight.c

+5 −5
Original line number Diff line number Diff line
@@ -638,7 +638,7 @@ static int isight_probe(struct fw_unit *unit, 
	if (!isight->audio_base) {

		dev_err(&unit->device, "audio unit base not found\n");

		err = -ENXIO;

		goto err_unit;

		goto error;

	}

	fw_iso_resources_init(&isight->resources, unit);
@@ -667,12 +667,12 @@ static int isight_probe(struct fw_unit *unit, 
	dev_set_drvdata(&unit->device, isight);



	return 0;



err_unit:

	fw_unit_put(isight->unit);

	mutex_destroy(&isight->mutex);

error:

	snd_card_free(card);



	mutex_destroy(&isight->mutex);

	fw_unit_put(isight->unit);



	return err;

}