Commit 515ab7c4 authored Jan 31, 2018 by Nadav Amit Committed by Ingo Molnar Feb 13, 2018

x86/mm: Align TLB invalidation info



The TLB invalidation info is allocated on the stack, which might cause
it to be unaligned. Since this information may be transferred to
different cores for TLB shootdown, this may cause an additional cache
line to become shared. While the overhead is likely to be small, the
fix is simple.

We do not use __cacheline_aligned() since it also defines the section,
which is inappropriate for stack variables.

Signed-off-by: Nadav Amit <namit@vmware.com>
Acked-by: Andy Lutomirski <luto@kernel.org>
Cc: Dave Hansen <dave.hansen@linux.intel.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Nadav Amit <nadav.amit@gmail.com>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Thomas Gleixner <tglx@linutronix.de>
Link: http://lkml.kernel.org/r/20180131211912.52064-1-namit@vmware.com


Signed-off-by: Ingo Molnar <mingo@kernel.org>

parent 178e834c

arch/x86/mm/tlb.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -613,7 +613,7 @@ void flush_tlb_mm_range(struct mm_struct *mm, unsigned long start,
		{
		int cpu;

		struct flush_tlb_info info = {
		struct flush_tlb_info info __aligned(SMP_CACHE_BYTES) = {
		.mm = mm,
		};