Commit 513aa3b0 authored Sep 20, 2012 by Johannes Berg

iwlwifi: fix async station command crash



Before Emmanuel's change to use a copy of the command
("iwlwifi: get the correct HCMD in the response handler")
the iwl_add_sta_callback() function would have used a
random pointer to somewhere when processing responses
to an async command, while that wasn't valid data it
was at least a valid pointer. Now, the pointer will be
NULL in this case, thus crashing.

Fix this by exiting the function early if no command
is passed back which means it was sent asynchronously.

Reviewed-by: Emmanuel Grumbach <emmanuel.grumbach@intel.com>
Signed-off-by: Johannes Berg <johannes.berg@intel.com>

parent ca42613a

drivers/net/wireless/iwlwifi/dvm/sta.c

+4 −3

Original line number	Diff line number	Diff line
		@@ -128,10 +128,11 @@ int iwl_add_sta_callback(struct iwl_priv priv, struct iwl_rx_cmd_buffer rxb,
		struct iwl_device_cmd *cmd)
		{
		struct iwl_rx_packet *pkt = rxb_addr(rxb);
		struct iwl_addsta_cmd *addsta =
		(struct iwl_addsta_cmd *) cmd->payload;

		return iwl_process_add_sta_resp(priv, addsta, pkt);
		if (!cmd)
		return 0;

		return iwl_process_add_sta_resp(priv, (void *)cmd->payload, pkt);
		}

		int iwl_send_add_sta(struct iwl_priv *priv,