Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 5080e28d authored by YueHaibing's avatar YueHaibing Committed by David S. Miller
Browse files

net: mvpp2: cls: Remove unnessesary check in mvpp2_ethtool_cls_rule_ins 



Fix smatch warning:

drivers/net/ethernet/marvell/mvpp2/mvpp2_cls.c:1236
 mvpp2_ethtool_cls_rule_ins() warn: unsigned 'info->fs.location' is never less than zero.

'info->fs.location' is u32 type, never less than zero.

Signed-off-by: default avatarYueHaibing <yuehaibing@huawei.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 9737070c

drivers/net/ethernet/marvell/mvpp2/mvpp2_cls.c

+1 −2
Original line number Diff line number Diff line
@@ -1300,8 +1300,7 @@ int mvpp2_ethtool_cls_rule_ins(struct mvpp2_port *port, 
	struct mvpp2_ethtool_fs *efs, *old_efs;

	int ret = 0;



	if (info->fs.location >= MVPP2_N_RFS_ENTRIES_PER_FLOW ||

	    info->fs.location < 0)

	if (info->fs.location >= MVPP2_N_RFS_ENTRIES_PER_FLOW)

		return -EINVAL;



	efs = kzalloc(sizeof(*efs), GFP_KERNEL);