Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 50636af7 authored by Eric Dumazet's avatar Eric Dumazet Committed by David S. Miller
Browse files

xt_tee: use skb_dst_drop() 



After commit 7fee226a (net: add a noref bit on skb dst), its wrong to
use : dst_release(skb_dst(skb)), since we could decrement a refcount
while skb dst was not refcounted.

We should use skb_dst_drop(skb) instead.

Signed-off-by: default avatarEric Dumazet <eric.dumazet@gmail.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 418bd0d4

net/netfilter/xt_TEE.c

+2 −2
Original line number Diff line number Diff line
@@ -76,7 +76,7 @@ tee_tg_route4(struct sk_buff *skb, const struct xt_tee_tginfo *info) 
	if (ip_route_output_key(net, &rt, &fl) != 0)

		return false;



	dst_release(skb_dst(skb));

	skb_dst_drop(skb);

	skb_dst_set(skb, &rt->u.dst);

	skb->dev      = rt->u.dst.dev;

	skb->protocol = htons(ETH_P_IP);
@@ -157,7 +157,7 @@ tee_tg_route6(struct sk_buff *skb, const struct xt_tee_tginfo *info) 
	if (dst == NULL)

		return false;



	dst_release(skb_dst(skb));

	skb_dst_drop(skb);

	skb_dst_set(skb, dst);

	skb->dev      = dst->dev;

	skb->protocol = htons(ETH_P_IPV6);