Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 5009aead authored by Dan Carpenter's avatar Dan Carpenter Committed by Greg Kroah-Hartman
Browse files

ALSA: firewire-digi00x: prevent potential use after free 



[ Upstream commit c0e72058d5e21982e61a29de6b098f7c1f0db498 ]

This code was supposed to return an error code if init_stream()
failed, but it instead freed dg00x->rx_stream and returned success.
This potentially leads to a use after free.

Fixes: 9a08067e ("ALSA: firewire-digi00x: support AMDTP domain")
Signed-off-by: default avatarDan Carpenter <dan.carpenter@linaro.org>
Link: https://lore.kernel.org/r/c224cbd5-d9e2-4cd4-9bcf-2138eb1d35c6@kili.mountain


Signed-off-by: default avatarTakashi Iwai <tiwai@suse.de>
Signed-off-by: default avatarSasha Levin <sashal@kernel.org>
parent b22b5142

sound/firewire/digi00x/digi00x-stream.c

+3 −1
Original line number Diff line number Diff line
@@ -259,8 +259,10 @@ int snd_dg00x_stream_init_duplex(struct snd_dg00x *dg00x) 
		return err;



	err = init_stream(dg00x, &dg00x->tx_stream);

	if (err < 0)

	if (err < 0) {

		destroy_stream(dg00x, &dg00x->rx_stream);

		return err;

	}



	err = amdtp_domain_init(&dg00x->domain);

	if (err < 0) {