Commit 4ff69cf3 authored Nov 05, 2021 by Chengfeng Ye Committed by Greg Kroah-Hartman Jan 27, 2022

HSI: core: Fix return freed object in hsi_new_client



[ Upstream commit a1ee1c08fcd5af03187dcd41dcab12fd5b379555 ]

cl is freed on error of calling device_register, but this
object is return later, which will cause uaf issue. Fix it
by return NULL on error.

Signed-off-by: Chengfeng Ye <cyeaa@connect.ust.hk>
Signed-off-by: Sebastian Reichel <sebastian.reichel@collabora.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>

parent 009d6d9f

drivers/hsi/hsi_core.c

+1 −0

Original line number	Diff line number	Diff line
		@@ -102,6 +102,7 @@ struct hsi_client hsi_new_client(struct hsi_port port,
		if (device_register(&cl->device) < 0) {
		pr_err("hsi: failed to register client: %s\n", info->name);
		put_device(&cl->device);
		goto err;
		}

		return cl;