Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 4ff3a9d1 authored by Herbert Xu's avatar Herbert Xu Committed by Johannes Berg
Browse files

mac80211: Free mpath object when rhashtable insertion fails 



When rhashtable insertion fails the mesh table code doesn't free
the now-orphan mesh path object.  This patch fixes that.

Cc: stable@vger.kernel.org
Signed-off-by: default avatarHerbert Xu <herbert@gondor.apana.org.au>
Signed-off-by: default avatarJohannes Berg <johannes.berg@intel.com>
parent b4c3fbe6

net/mac80211/mesh_pathtbl.c

+9 −8
Original line number Diff line number Diff line
@@ -436,17 +436,15 @@ struct mesh_path *mesh_path_add(struct ieee80211_sub_if_data *sdata, 
	} while (unlikely(ret == -EEXIST && !mpath));

	spin_unlock_bh(&tbl->walk_lock);



	if (ret && ret != -EEXIST)

	if (ret) {

		kfree(new_mpath);



		if (ret != -EEXIST)

			return ERR_PTR(ret);



	/* At this point either new_mpath was added, or we found a

	 * matching entry already in the table; in the latter case

	 * free the unnecessary new entry.

	 */

	if (ret == -EEXIST) {

		kfree(new_mpath);

		new_mpath = mpath;

	}



	sdata->u.mesh.mesh_paths_generation++;

	return new_mpath;

}
@@ -481,6 +479,9 @@ int mpp_path_add(struct ieee80211_sub_if_data *sdata, 
		hlist_add_head_rcu(&new_mpath->walk_list, &tbl->walk_head);

	spin_unlock_bh(&tbl->walk_lock);



	if (ret)

		kfree(new_mpath);



	sdata->u.mesh.mpp_paths_generation++;

	return ret;

}