Commit 4fed1b12 authored Feb 03, 2017 by Jan Beulich Committed by Boris Ostrovsky Feb 03, 2017

xen/manage: correct return value check on xenbus_scanf()



A negative return value indicates an error; in fact the function at
present won't ever return zero.

Signed-off-by: Jan Beulich <jbeulich@suse.com>
Reviewed-by: Juergen Gross <jgross@suse.com>
Signed-off-by: Boris Ostrovsky <boris.ostrovsky@oracle.com>

parent cc272163

drivers/xen/manage.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -277,7 +277,7 @@ static void sysrq_handler(struct xenbus_watch watch, const char *vec,
		err = xenbus_transaction_start(&xbt);
		if (err)
		return;
		if (!xenbus_scanf(xbt, "control", "sysrq", "%c", &sysrq_key)) {
		if (xenbus_scanf(xbt, "control", "sysrq", "%c", &sysrq_key) < 0) {
		pr_err("Unable to read sysrq code in control/sysrq\n");
		xenbus_transaction_end(xbt, 1);
		return;