Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 4faa6308 authored by Jia-Ju Bai's avatar Jia-Ju Bai Committed by Greg Kroah-Hartman
Browse files

md: bcache: check the return value of kzalloc() in detached_dev_do_request() 



commit 40f567bbb3b0639d2ec7d1c6ad4b1b018f80cf19 upstream.

The function kzalloc() in detached_dev_do_request() can fail, so its
return value should be checked.

Fixes: bc082a55 ("bcache: fix inaccurate io state for detached bcache devices")
Reported-by: default avatarTOTE Robot <oslab@tsinghua.edu.cn>
Signed-off-by: default avatarJia-Ju Bai <baijiaju1990@gmail.com>
Signed-off-by: default avatarColy Li <colyli@suse.de>
Link: https://lore.kernel.org/r/20220527152818.27545-4-colyli@suse.de


Signed-off-by: default avatarJens Axboe <axboe@kernel.dk>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 5f62b21b

drivers/md/bcache/request.c

+6 −0
Original line number Original line Diff line number Diff line
@@ -1119,6 +1119,12 @@ static void detached_dev_do_request(struct bcache_device *d, struct bio *bio) 
	 * which would call closure_get(&dc->disk.cl)

	 * which would call closure_get(&dc->disk.cl)

	 */

	 */

	ddip = kzalloc(sizeof(struct detached_dev_io_private), GFP_NOIO);

	ddip = kzalloc(sizeof(struct detached_dev_io_private), GFP_NOIO);

	if (!ddip) {

		bio->bi_status = BLK_STS_RESOURCE;

		bio->bi_end_io(bio);

		return;

	}



	ddip->d = d;

	ddip->d = d;

	ddip->start_time = jiffies;

	ddip->start_time = jiffies;

	ddip->bi_end_io = bio->bi_end_io;

	ddip->bi_end_io = bio->bi_end_io;