Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 4f969d07 authored by Adrian Hunter's avatar Adrian Hunter Committed by Greg Kroah-Hartman
Browse files

perf auxtrace: Fix address filter symbol name match for modules 



commit cba04f3136b658583adb191556f99d087589c1cc upstream.

For modules, names from kallsyms__parse() contain the module name which
meant that module symbols did not match exactly by name.

Fix by matching the name string up to the separating tab character.

Fixes: 1b36c03e ("perf record: Add support for using symbols in address filters")
Signed-off-by: default avatarAdrian Hunter <adrian.hunter@intel.com>
Cc: Adrian Hunter <adrian.hunter@intel.com>
Cc: Ian Rogers <irogers@google.com>
Cc: Jiri Olsa <jolsa@kernel.org>
Cc: Namhyung Kim <namhyung@kernel.org>
Cc: stable@vger.kernel.org
Link: https://lore.kernel.org/r/20221026072736.2982-1-adrian.hunter@intel.com


Signed-off-by: default avatarArnaldo Carvalho de Melo <acme@redhat.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent c78b0dc6

tools/perf/util/auxtrace.c

+9 −1
Original line number Diff line number Diff line
@@ -1710,11 +1710,19 @@ struct sym_args { 
	bool		near;

};



static bool kern_sym_name_match(const char *kname, const char *name)

{

	size_t n = strlen(name);



	return !strcmp(kname, name) ||

	       (!strncmp(kname, name, n) && kname[n] == '\t');

}



static bool kern_sym_match(struct sym_args *args, const char *name, char type)

{

	/* A function with the same name, and global or the n'th found or any */

	return kallsyms__is_function(type) &&

	       !strcmp(name, args->name) &&

	       kern_sym_name_match(name, args->name) &&

	       ((args->global && isupper(type)) ||

		(args->selected && ++(args->cnt) == args->idx) ||

		(!args->global && !args->selected));