Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 4f70daa0 authored by Jacob Keller's avatar Jacob Keller Committed by Jeff Kirsher
Browse files

ice: Use a different ICE_DBG bit for firmware log messages 



Replace the use of the ICE_DBG_AQ_MSG bit when dumping firmware logging
messages with a separate distinct type ICE_DBG_FW_LOG. This is useful
so that developers may enable ICE_DBG_FW_LOG and get firmware logging
messages, without also dumping AdminQ messages at the same time.

Signed-off-by: default avatarJacob Keller <jacob.e.keller@intel.com>
Signed-off-by: default avatarAnirudh Venkataramanan <anirudh.venkataramanan@intel.com>
Tested-by: default avatarAndrew Bowers <andrewx.bowers@intel.com>
Signed-off-by: default avatarJeff Kirsher <jeffrey.t.kirsher@intel.com>
parent ed14245a

drivers/net/ethernet/intel/ice/ice_common.c

+3 −3
Original line number Diff line number Diff line
@@ -681,10 +681,10 @@ static enum ice_status ice_cfg_fw_log(struct ice_hw *hw, bool enable) 
 */

void ice_output_fw_log(struct ice_hw *hw, struct ice_aq_desc *desc, void *buf)

{

	ice_debug(hw, ICE_DBG_AQ_MSG, "[ FW Log Msg Start ]\n");

	ice_debug_array(hw, ICE_DBG_AQ_MSG, 16, 1, (u8 *)buf,

	ice_debug(hw, ICE_DBG_FW_LOG, "[ FW Log Msg Start ]\n");

	ice_debug_array(hw, ICE_DBG_FW_LOG, 16, 1, (u8 *)buf,

			le16_to_cpu(desc->datalen));

	ice_debug(hw, ICE_DBG_AQ_MSG, "[ FW Log Msg End ]\n");

	ice_debug(hw, ICE_DBG_FW_LOG, "[ FW Log Msg End ]\n");

}



/**

drivers/net/ethernet/intel/ice/ice_type.h

+1 −0
Original line number Diff line number Diff line
@@ -23,6 +23,7 @@ static inline bool ice_is_tc_ena(u8 bitmap, u8 tc) 


/* debug masks - set these bits in hw->debug_mask to control output */

#define ICE_DBG_INIT		BIT_ULL(1)

#define ICE_DBG_FW_LOG		BIT_ULL(3)

#define ICE_DBG_LINK		BIT_ULL(4)

#define ICE_DBG_PHY		BIT_ULL(5)

#define ICE_DBG_QCTX		BIT_ULL(6)