Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 4f0129d1 authored by Raveendra Padasalagi's avatar Raveendra Padasalagi Committed by Herbert Xu
Browse files

crypto: bcm - fix normal/non key hash algorithm failure 



Remove setkey() callback handler for normal/non key
hash algorithms and keep it for AES-CBC/CMAC which needs key.

Fixes: 9d12ba86 ("crypto: brcm - Add Broadcom SPU driver")
Signed-off-by: default avatarRaveendra Padasalagi <raveendra.padasalagi@broadcom.com>
Signed-off-by: default avatarHerbert Xu <herbert@gondor.apana.org.au>
parent ecd6d5c9

drivers/crypto/bcm/cipher.c

+5 −1
Original line number Diff line number Diff line
@@ -4652,12 +4652,16 @@ static int spu_register_ahash(struct iproc_alg_s *driver_alg) 
	hash->halg.statesize = sizeof(struct spu_hash_export_s);



	if (driver_alg->auth_info.mode != HASH_MODE_HMAC) {

		hash->setkey = ahash_setkey;

		hash->init = ahash_init;

		hash->update = ahash_update;

		hash->final = ahash_final;

		hash->finup = ahash_finup;

		hash->digest = ahash_digest;

		if ((driver_alg->auth_info.alg == HASH_ALG_AES) &&

		    ((driver_alg->auth_info.mode == HASH_MODE_XCBC) ||

		    (driver_alg->auth_info.mode == HASH_MODE_CMAC))) {

			hash->setkey = ahash_setkey;

		}

	} else {

		hash->setkey = ahash_hmac_setkey;

		hash->init = ahash_hmac_init;