Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 4ecff6ee authored by Chuhong Yuan's avatar Chuhong Yuan Committed by Greg Kroah-Hartman
Browse files

iio: mma8452: Add missed iio_device_unregister() call in mma8452_probe() 



commit d7369ae1f4d7cffa7574d15e1f787dcca184c49d upstream.

The function iio_device_register() was called in mma8452_probe().
But the function iio_device_unregister() was not called after
a call of the function mma8452_set_freefall_mode() failed.
Thus add the missed function call for one error case.

Fixes: 1a965d40 ("drivers:iio:accel:mma8452: added cleanup provision in case of failure.")
Signed-off-by: default avatarChuhong Yuan <hslester96@gmail.com>
Cc: <Stable@vger.kernel.org>
Signed-off-by: default avatarJonathan Cameron <Jonathan.Cameron@huawei.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent b4172e02

drivers/iio/accel/mma8452.c

+4 −1
Original line number Diff line number Diff line
@@ -1685,10 +1685,13 @@ static int mma8452_probe(struct i2c_client *client, 


	ret = mma8452_set_freefall_mode(data, false);

	if (ret < 0)

		goto buffer_cleanup;

		goto unregister_device;



	return 0;



unregister_device:

	iio_device_unregister(indio_dev);



buffer_cleanup:

	iio_triggered_buffer_cleanup(indio_dev);