Commit 4ec850e5 authored Mar 12, 2019 by Kangjie Lu Committed by David S. Miller Mar 12, 2019

net: dwmac-sun8i: fix a missing check of of_get_phy_mode



of_get_phy_mode may fail and return a negative error code;
the fix checks the return value of of_get_phy_mode and
returns -EINVAL of it fails.

Signed-off-by: Kangjie Lu <kjlu@umn.edu>
Acked-by: Maxime Ripard <maxime.ripard@bootlin.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent 035a14e7

drivers/net/ethernet/stmicro/stmmac/dwmac-sun8i.c

+4 −1

Original line number	Diff line number	Diff line
		@@ -1147,7 +1147,10 @@ static int sun8i_dwmac_probe(struct platform_device *pdev)
		return ret;
		}

		plat_dat->interface = of_get_phy_mode(dev->of_node);
		ret = of_get_phy_mode(dev->of_node);
		if (ret < 0)
		return -EINVAL;
		plat_dat->interface = ret;

		/* platform data specifying hardware features and callbacks.
		* hardware features were copied from Allwinner drivers.