Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 4e6b26d2 authored by Thomas Gleixner's avatar Thomas Gleixner
Browse files

PCI/MSI: Remove obsolete sanity checks for multiple interrupt sets



Multiple interrupt sets for affinity spreading are now handled in the core
code and the number of sets and their size is recalculated via a driver
supplied callback.

That avoids the requirement to invoke pci_alloc_irq_vectors_affinity() with
the arguments minvecs and maxvecs set to the same value and the callsite
handling the ENOSPC situation.

Remove the now obsolete sanity checks and the related comments.

Signed-off-by: default avatarThomas Gleixner <tglx@linutronix.de>
Reviewed-by: default avatarMing Lei <ming.lei@redhat.com>
Acked-by: default avatarMarc Zyngier <marc.zyngier@arm.com>
Cc: Christoph Hellwig <hch@lst.de>
Cc: Bjorn Helgaas <helgaas@kernel.org>
Cc: Jens Axboe <axboe@kernel.dk>
Cc: linux-block@vger.kernel.org
Cc: Sagi Grimberg <sagi@grimberg.me>
Cc: linux-nvme@lists.infradead.org
Cc: linux-pci@vger.kernel.org
Cc: Keith Busch <keith.busch@intel.com>
Cc: Sumit Saxena <sumit.saxena@broadcom.com>
Cc: Kashyap Desai <kashyap.desai@broadcom.com>
Cc: Shivasharan Srikanteshwara <shivasharan.srikanteshwara@broadcom.com>
Link: https://lkml.kernel.org/r/20190216172228.778630549@linutronix.de
parent a6a309ed
Loading
Loading
Loading
Loading
+0 −14
Original line number Diff line number Diff line
@@ -1035,13 +1035,6 @@ static int __pci_enable_msi_range(struct pci_dev *dev, int minvec, int maxvec,
	if (maxvec < minvec)
		return -ERANGE;

	/*
	 * If the caller is passing in sets, we can't support a range of
	 * vectors. The caller needs to handle that.
	 */
	if (affd && affd->nr_sets && minvec != maxvec)
		return -EINVAL;

	if (WARN_ON_ONCE(dev->msi_enabled))
		return -EINVAL;

@@ -1093,13 +1086,6 @@ static int __pci_enable_msix_range(struct pci_dev *dev,
	if (maxvec < minvec)
		return -ERANGE;

	/*
	 * If the caller is passing in sets, we can't support a range of
	 * supported vectors. The caller needs to handle that.
	 */
	if (affd && affd->nr_sets && minvec != maxvec)
		return -EINVAL;

	if (WARN_ON_ONCE(dev->msix_enabled))
		return -EINVAL;