Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 4e3c7c00 authored by YueHaibing's avatar YueHaibing Committed by David S. Miller
Browse files

net: aquantia: return 'err' if set MPI_DEINIT state fails 



Fixes gcc '-Wunused-but-set-variable' warning:

drivers/net/ethernet/aquantia/atlantic/hw_atl/hw_atl_utils.c:260:7:
 warning: variable 'err' set but not used [-Wunused-but-set-variable]

'err' should be returned while set MPI_DEINIT state fails
in hw_atl_utils_soft_reset.

Fixes: cce96d18 ("net: aquantia: Regression on reset with 1.x firmware")
Signed-off-by: default avatarYueHaibing <yuehaibing@huawei.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent ff223789

drivers/net/ethernet/aquantia/atlantic/hw_atl/hw_atl_utils.c

+2 −0
Original line number Diff line number Diff line
@@ -263,6 +263,8 @@ int hw_atl_utils_soft_reset(struct aq_hw_s *self) 
		AQ_HW_WAIT_FOR((aq_hw_read_reg(self, HW_ATL_MPI_STATE_ADR) &

				HW_ATL_MPI_STATE_MSK) == MPI_DEINIT,

			       10, 1000U);

		if (err)

			return err;

	}



	if (self->rbl_enabled)