Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 4e303fbe authored by Arnaldo Carvalho de Melo's avatar Arnaldo Carvalho de Melo
Browse files

perf top: Allow disabling the overwrite mode 



In ebebbf08 ("perf top: Switch default mode to overwrite mode") we
forgot to leave a way to disable that new default, add a --overwrite
option that can be disabled using --no-overwrite, since the code already
in such a way that we can readily disable this mode.

This is useful when investigating bugs with this mode like the recent
report from David Miller where lots of unknown symbols appear due to
disabling the events while processing them which disables all record
types, not just PERF_RECORD_SAMPLE, which makes it impossible to resolve
maps when we lose PERF_RECORD_MMAP records.

This can be easily seen while building a kernel, when there are lots of
short lived processes.

Reported-by: default avatarDavid Miller <davem@davemloft.net>
Acked-by: default avatarKan Liang <kan.liang@intel.com>
Cc: Adrian Hunter <adrian.hunter@intel.com>
Cc: Andi Kleen <ak@linux.intel.com>
Cc: David Ahern <dsahern@gmail.com>
Cc: Jin Yao <yao.jin@linux.intel.com>
Cc: Jiri Olsa <jolsa@kernel.org>
Cc: Namhyung Kim <namhyung@kernel.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Wang Nan <wangnan0@huawei.com>
Fixes: ebebbf08 ("perf top: Switch default mode to overwrite mode")
Link: https://lkml.kernel.org/n/tip-oqgsz2bq4kgrnnajrafcdhie@git.kernel.org


Signed-off-by: default avatarArnaldo Carvalho de Melo <acme@redhat.com>
parent 23c07a23

tools/perf/Documentation/perf-top.txt

+5 −0
Original line number Diff line number Diff line
@@ -242,6 +242,11 @@ Default is to monitor all CPUS. 
--hierarchy::

	Enable hierarchy output.



--overwrite::

	This is the default, but for investigating problems with it or any other strange

	behaviour like lots of unknown samples, we may want to disable this mode by using

	--no-overwrite.



--force::

	Don't do ownership validation.

tools/perf/builtin-top.c

+2 −0
Original line number Diff line number Diff line
@@ -1372,6 +1372,8 @@ int cmd_top(int argc, const char **argv) 
		    "Show raw trace event output (do not use print fmt or plugins)"),

	OPT_BOOLEAN(0, "hierarchy", &symbol_conf.report_hierarchy,

		    "Show entries in a hierarchy"),

	OPT_BOOLEAN(0, "overwrite", &top.record_opts.overwrite,

		    "Use a backward ring buffer, default: yes"),

	OPT_BOOLEAN(0, "force", &symbol_conf.force, "don't complain, do it"),

	OPT_UINTEGER(0, "num-thread-synthesize", &top.nr_threads_synthesize,

			"number of thread to run event synthesize"),