Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 4dd75b33 authored by Richard Weinberger's avatar Richard Weinberger
Browse files

ubifs: Fix double unlock around orphan_delete() 



We unlock after orphan_delete(), so no need to unlock
in the function too.

Reported-by: default avatarHan Xu <han.xu@nxp.com>
Fixes: 8009ce95 ("ubifs: Don't leak orphans on memory during commit")
Signed-off-by: default avatarRichard Weinberger <richard@nod.at>
parent 7542c6de

fs/ubifs/orphan.c

+0 −2
Original line number Diff line number Diff line
@@ -129,7 +129,6 @@ static void __orphan_drop(struct ubifs_info *c, struct ubifs_orphan *o) 
static void orphan_delete(struct ubifs_info *c, struct ubifs_orphan *orph)

{

	if (orph->del) {

		spin_unlock(&c->orphan_lock);

		dbg_gen("deleted twice ino %lu", orph->inum);

		return;

	}
@@ -138,7 +137,6 @@ static void orphan_delete(struct ubifs_info *c, struct ubifs_orphan *orph) 
		orph->del = 1;

		orph->dnext = c->orph_dnext;

		c->orph_dnext = orph;

		spin_unlock(&c->orphan_lock);

		dbg_gen("delete later ino %lu", orph->inum);

		return;

	}