Commit 4d97b691 authored Mar 22, 2016 by Bhaktipriya Shridhar Committed by Greg Kroah-Hartman Mar 28, 2016

staging: rtl8712: mlme_linux: Clean up tests if NULL returned on failure



Some functions like kzalloc return NULL on failure.
When NULL represents failure, !x is commonly used.

This was done using Coccinelle:

@@
expression *e;
identifier l1;
@@

e = \(kmalloc\|kzalloc\|kcalloc\|devm_kzalloc\)(...);
...
- e == NULL
+ !e

Signed-off-by: Bhaktipriya Shridhar <bhaktipriya96@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

parent 06884afc

drivers/staging/rtl8712/mlme_linux.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -153,7 +153,7 @@ void r8712_report_sec_ie(struct _adapter adapter, u8 authmode, u8 sec_ie)
		buff = NULL;
		if (authmode == _WPA_IE_ID_) {
		buff = kzalloc(IW_CUSTOM_MAX, GFP_ATOMIC);
		if (buff == NULL)
		if (!buff)
		return;
		p = buff;
		p += sprintf(p, "ASSOCINFO(ReqIEs=");