Commit 4d86c9f7 authored Mar 26, 2019 by Nathan Chancellor Committed by Daniel Lezcano Apr 16, 2019

clocksource/drivers/timer-ti-dm: Remove omap_dm_timer_set_load_start



Commit 008258d9 ("clocksource/drivers/timer-ti-dm: Make
omap_dm_timer_set_load_start() static") made omap_dm_time_set_load_start
static because its prototype was not defined in a header. Unfortunately,
this causes a build warning on multi_v7_defconfig because this function
is not used anywhere in this translation unit:

drivers/clocksource/timer-ti-dm.c:589:12: error: unused function
'omap_dm_timer_set_load_start' [-Werror,-Wunused-function]

In fact, omap_dm_timer_set_load_start hasn't been used anywhere since
commit f190be7f ("staging: tidspbridge: remove driver") and the
prototype was removed in commit 592ea6bd ("clocksource: timer-ti-dm:
Make unexported functions static"), which is probably where this should
have happened.

Fixes: 592ea6bd ("clocksource: timer-ti-dm: Make unexported functions static")
Fixes: 008258d9 ("clocksource/drivers/timer-ti-dm: Make omap_dm_timer_set_load_start() static")
Signed-off-by: Nathan Chancellor <natechancellor@gmail.com>
Acked-by: Tony Lindgren <tony@atomide.com>
Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org>

parent fbc87aa0

drivers/clocksource/timer-ti-dm.c

+0 −28

Original line number	Diff line number	Diff line
		@@ -585,34 +585,6 @@ static int omap_dm_timer_set_load(struct omap_dm_timer *timer, int autoreload,
		return 0;
		}

		/* Optimized set_load which removes costly spin wait in timer_start */
		static int omap_dm_timer_set_load_start(struct omap_dm_timer *timer,
		int autoreload, unsigned int load)
		{
		u32 l;

		if (unlikely(!timer))
		return -EINVAL;

		omap_dm_timer_enable(timer);

		l = omap_dm_timer_read_reg(timer, OMAP_TIMER_CTRL_REG);
		if (autoreload) {
		l \|= OMAP_TIMER_CTRL_AR;
		omap_dm_timer_write_reg(timer, OMAP_TIMER_LOAD_REG, load);
		} else {
		l &= ~OMAP_TIMER_CTRL_AR;
		}
		l \|= OMAP_TIMER_CTRL_ST;

		__omap_dm_timer_load_start(timer, l, load, timer->posted);

		/* Save the context */
		timer->context.tclr = l;
		timer->context.tldr = load;
		timer->context.tcrr = load;
		return 0;
		}
		static int omap_dm_timer_set_match(struct omap_dm_timer *timer, int enable,
		unsigned int match)
		{