Commit 4d3dc0de authored Nov 15, 2022 by Dan Carpenter Committed by Greg Kroah-Hartman Jan 18, 2023

amdgpu/pm: prevent array underflow in vega20_odn_edit_dpm_table()



[ Upstream commit d27252b5706e51188aed7647126e44dcf9e940c1 ]

In the PP_OD_EDIT_VDDC_CURVE case the "input_index" variable is capped at
2 but not checked for negative values so it results in an out of bounds
read.  This value comes from the user via sysfs.

Fixes: d5bf2653 ("drm/amd/powerplay: added vega20 overdrive support V3")
Signed-off-by: Dan Carpenter <error27@gmail.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>

parent d39937f8

drivers/gpu/drm/amd/powerplay/hwmgr/vega20_hwmgr.c

+2 −1

Original line number	Diff line number	Diff line
		@@ -2894,7 +2894,8 @@ static int vega20_odn_edit_dpm_table(struct pp_hwmgr *hwmgr,
		data->od8_settings.od8_settings_array;
		OverDriveTable_t *od_table =
		&(data->smc_state_table.overdrive_table);
		int32_t input_index, input_clk, input_vol, i;
		int32_t input_clk, input_vol, i;
		uint32_t input_index;
		int od8_id;
		int ret;