Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 4d35028f authored by Nuno Sa's avatar Nuno Sa Committed by Greg Kroah-Hartman
Browse files

dmaengine: axi-dmac: fix possible race in remove() 



commit 1bc31444209c8efae98cb78818131950d9a6f4d6 upstream.

We need to first free the IRQ before calling of_dma_controller_free().
Otherwise we could get an interrupt and schedule a tasklet while
removing the DMA controller.

Fixes: 0e3b67b3 ("dmaengine: Add support for the Analog Devices AXI-DMAC DMA controller")
Cc: stable@kernel.org
Signed-off-by: default avatarNuno Sa <nuno.sa@analog.com>
Link: https://lore.kernel.org/r/20240328-axi-dmac-devm-probe-v3-1-523c0176df70@analog.com


Signed-off-by: default avatarVinod Koul <vkoul@kernel.org>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 5edb09d6

drivers/dma/dma-axi-dmac.c

+1 −1
Original line number Diff line number Diff line
@@ -947,8 +947,8 @@ static int axi_dmac_remove(struct platform_device *pdev) 
{

	struct axi_dmac *dmac = platform_get_drvdata(pdev);



	of_dma_controller_free(pdev->dev.of_node);

	free_irq(dmac->irq, dmac);

	of_dma_controller_free(pdev->dev.of_node);

	tasklet_kill(&dmac->chan.vchan.task);

	dma_async_device_unregister(&dmac->dma_dev);

	clk_disable_unprepare(dmac->clk);