Commit 4d2e11d4 authored Apr 04, 2019 by Colin Ian King Committed by Jason Gunthorpe Apr 08, 2019

opa_vnic: fix check on record->event, incorrect operator used



The check on record->event is always true because the wrong operator
is being used, used && instead of ||

Addresses-Coverity: ("Constant expression result")
Fixes: fae7a699 ("opa_vnic: Convert vport_idr to XArray")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
Acked-by: Dennis Dalessandro <dennis.dalessandro@intel.com>
Reviewed-by: Mukesh Ojha <mojha@codeaurora.org>
Signed-off-by: Jason Gunthorpe <jgg@mellanox.com>

parent d10bcf94

drivers/infiniband/ulp/opa_vnic/opa_vnic_vema.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -869,7 +869,7 @@ static void opa_vnic_event(struct ib_event_handler *handler,
		record->event, dev_name(&record->device->dev),
		record->element.port_num);

		if (record->event != IB_EVENT_PORT_ERR \|\|
		if (record->event != IB_EVENT_PORT_ERR &&
		record->event != IB_EVENT_PORT_ACTIVE)
		return;