Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 4d26ec5d authored by Sangjung Woo's avatar Sangjung Woo Committed by Tomi Valkeinen
Browse files

fbdev: sh_mobile_hdmi: Use devm_kzalloc() 



Use devm_kzalloc() instead of kzalloc() in order to be free
automatically. This makes cleanup paths more simple.

Signed-off-by: default avatarSangjung Woo <sangjung.woo@samsung.com>
Acked-by: default avatarLaurent Pinchart <laurent.pinchart@ideasonboard.com>
Signed-off-by: default avatarTomi Valkeinen <tomi.valkeinen@ti.com>
parent 55be3108

drivers/video/sh_mobile_hdmi.c

+2 −5
Original line number Diff line number Diff line
@@ -1290,7 +1290,7 @@ static int __init sh_hdmi_probe(struct platform_device *pdev) 
		}

	}



	hdmi = kzalloc(sizeof(*hdmi), GFP_KERNEL);

	hdmi = devm_kzalloc(&pdev->dev, sizeof(*hdmi), GFP_KERNEL);

	if (!hdmi) {

		dev_err(&pdev->dev, "Cannot allocate device data\n");

		return -ENOMEM;
@@ -1304,7 +1304,7 @@ static int __init sh_hdmi_probe(struct platform_device *pdev) 
	if (IS_ERR(hdmi->hdmi_clk)) {

		ret = PTR_ERR(hdmi->hdmi_clk);

		dev_err(&pdev->dev, "Unable to get clock: %d\n", ret);

		goto egetclk;

		return ret;

	}



	/* select register access functions */
@@ -1407,8 +1407,6 @@ static int __init sh_hdmi_probe(struct platform_device *pdev) 
	clk_disable(hdmi->hdmi_clk);

erate:

	clk_put(hdmi->hdmi_clk);

egetclk:

	kfree(hdmi);



	return ret;

}
@@ -1433,7 +1431,6 @@ static int __exit sh_hdmi_remove(struct platform_device *pdev) 
		iounmap(hdmi->htop1);

	iounmap(hdmi->base);

	release_mem_region(res->start, resource_size(res));

	kfree(hdmi);



	return 0;

}