Commit 4d2233ec authored Sep 02, 2019 by Colin Ian King Committed by Greg Kroah-Hartman Sep 03, 2019

usb: cdns3: remove redundant assignment to ret on error exit path



In the case where an allocation fails for priv_ep ret is
assigned -ENOMEM and the code exits via the exit path 'err'.
The exit path returns -ENOMEM without using variable ret, so
the assingment is redundant and can be removed.

Addresses-Coverity: ("Unused value")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
Link: https://lore.kernel.org/r/20190902184334.27406-1-colin.king@canonical.com


Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

parent 35af2445

drivers/usb/cdns3/gadget.c

+1 −3

Original line number	Diff line number	Diff line
		@@ -2445,10 +2445,8 @@ static int cdns3_init_eps(struct cdns3_device *priv_dev)

		priv_ep = devm_kzalloc(priv_dev->dev, sizeof(*priv_ep),
		GFP_KERNEL);
		if (!priv_ep) {
		ret = -ENOMEM;
		if (!priv_ep)
		goto err;
		}

		/* set parent of endpoint object */
		priv_ep->cdns3_dev = priv_dev;