Commit 4d2097e5 authored Jun 26, 2014 by Russell King Committed by Mark Brown Jun 28, 2014

ASoC: kirkwood-i2s: fix pause handling some more



We still see the occasional timeout waiting for busy to clear.  As the
spec is contradictory, and we know that the current implementation
doesn't work, try an alternative interpretation from the spec.  This
one appears to work - I have yet to find any issue with it during my
testing over several months.

Signed-off-by: Russell King <rmk+kernel@arm.linux.org.uk>
Tested-by: Andrew Lunn <andrew@lunn.ch>
Signed-off-by: Mark Brown <broonie@linaro.org>

parent 2fbc3821

sound/soc/kirkwood/kirkwood-i2s.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -238,7 +238,7 @@ static int kirkwood_i2s_play_trigger(struct snd_pcm_substream *substream,
		uint32_t ctl, value;

		ctl = readl(priv->io + KIRKWOOD_PLAYCTL);
		if (ctl & KIRKWOOD_PLAYCTL_PAUSE) {
		if ((ctl & KIRKWOOD_PLAYCTL_ENABLE_MASK) == 0) {
		unsigned timeout = 5000;
		/*
		* The Armada510 spec says that if we enter pause mode, the