Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 4d191b1b authored by Marc Zyngier's avatar Marc Zyngier Committed by Bjorn Helgaas
Browse files

PCI/MSI: pci-xgene-msi: Fix CPU hotplug registration handling 



The conversion to the new hotplug state machine introduced a regression
where a successful hotplug registration would be treated as an error,
effectively disabling the MSI driver forever.

Fix it by doing the proper check on the return value.

Fixes: 9c248f88 ("PCI/xgene-msi: Convert to hotplug state machine")
Signed-off-by: default avatarMarc Zyngier <marc.zyngier@arm.com>
Signed-off-by: default avatarBjorn Helgaas <bhelgaas@google.com>
Acked-by: default avatarSebastian Andrzej Siewior <bigeasy@linutronix.de>
Tested-by: default avatarDuc Dang <dhdang@apm.com>
CC: Thomas Gleixner <tglx@linutronix.de>
CC: stable@vger.kernel.org
parent 51ebfc92

drivers/pci/host/pci-xgene-msi.c

+1 −1
Original line number Diff line number Diff line
@@ -517,7 +517,7 @@ static int xgene_msi_probe(struct platform_device *pdev) 


	rc = cpuhp_setup_state(CPUHP_AP_ONLINE_DYN, "pci/xgene:online",

			       xgene_msi_hwirq_alloc, NULL);

	if (rc)

	if (rc < 0)

		goto err_cpuhp;

	pci_xgene_online = rc;

	rc = cpuhp_setup_state(CPUHP_PCI_XGENE_DEAD, "pci/xgene:dead", NULL,