Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 4c8996d7 authored by Robin Murphy's avatar Robin Murphy Committed by Will Deacon
Browse files

iommu/arm-smmu-v3: Warn about missing IRQs 



It is annoyingly non-obvious when DMA transactions silently go missing
due to undetected SMMU faults. Help skip the first few debugging steps
in those situations by making it clear when we have neither wired IRQs
nor MSIs with which to raise error conditions.

Signed-off-by: default avatarRobin Murphy <robin.murphy@arm.com>
Signed-off-by: default avatarWill Deacon <will.deacon@arm.com>
parent 4a3928c6

drivers/iommu/arm-smmu-v3.c

+6 −0
Original line number Diff line number Diff line
@@ -2370,6 +2370,8 @@ static void arm_smmu_setup_unique_irqs(struct arm_smmu_device *smmu) 
						"arm-smmu-v3-evtq", smmu);

		if (ret < 0)

			dev_warn(smmu->dev, "failed to enable evtq irq\n");

	} else {

		dev_warn(smmu->dev, "no evtq irq - events will not be reported!\n");

	}



	irq = smmu->gerr_irq;
@@ -2378,6 +2380,8 @@ static void arm_smmu_setup_unique_irqs(struct arm_smmu_device *smmu) 
				       0, "arm-smmu-v3-gerror", smmu);

		if (ret < 0)

			dev_warn(smmu->dev, "failed to enable gerror irq\n");

	} else {

		dev_warn(smmu->dev, "no gerr irq - errors will not be reported!\n");

	}



	if (smmu->features & ARM_SMMU_FEAT_PRI) {
@@ -2391,6 +2395,8 @@ static void arm_smmu_setup_unique_irqs(struct arm_smmu_device *smmu) 
			if (ret < 0)

				dev_warn(smmu->dev,

					 "failed to enable priq irq\n");

		} else {

			dev_warn(smmu->dev, "no priq irq - PRI will be broken\n");

		}

	}

}