Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 4c44d463 authored by Fuqian Huang's avatar Fuqian Huang Committed by Jason Gunthorpe
Browse files

IB: Remove unneeded memset 

In commit af7ddd8a ("Merge tag 'dma-mapping-4.21' of
git://git.infradead.org/users/hch/dma-mapping"

),
dma_alloc_coherent/dmam_alloc_coherent always zeroed the returned memory.
So the memset after a coherent allocation function is not needed.

Signed-off-by: default avatarFuqian Huang <huangfq.daxian@gmail.com>
Reviewed-by: default avatarJason Gunthorpe <jgg@mellanox.com>
Signed-off-by: default avatarJason Gunthorpe <jgg@mellanox.com>
parent c5cfcfcb

drivers/infiniband/hw/cxgb3/cxio_hal.c

+0 −3
Original line number Diff line number Diff line
@@ -174,7 +174,6 @@ int cxio_create_cq(struct cxio_rdev *rdev_p, struct t3_cq *cq, int kernel) 
		return -ENOMEM;

	}

	dma_unmap_addr_set(cq, mapping, cq->dma_addr);

	memset(cq->queue, 0, size);

	setup.id = cq->cqid;

	setup.base_addr = (u64) (cq->dma_addr);

	setup.size = 1UL << cq->size_log2;
@@ -522,8 +521,6 @@ static int cxio_hal_init_ctrl_qp(struct cxio_rdev *rdev_p) 
	dma_unmap_addr_set(&rdev_p->ctrl_qp, mapping,

			   rdev_p->ctrl_qp.dma_addr);

	rdev_p->ctrl_qp.doorbell = (void __iomem *)rdev_p->rnic_info.kdb_addr;

	memset(rdev_p->ctrl_qp.workq, 0,

	       (1 << T3_CTRL_QP_SIZE_LOG2) * sizeof(union t3_wr));



	mutex_init(&rdev_p->ctrl_qp.lock);

	init_waitqueue_head(&rdev_p->ctrl_qp.waitq);

drivers/infiniband/hw/cxgb4/cq.c

+0 −1
Original line number Diff line number Diff line
@@ -102,7 +102,6 @@ static int create_cq(struct c4iw_rdev *rdev, struct t4_cq *cq, 
		goto err3;

	}

	dma_unmap_addr_set(cq, mapping, cq->dma_addr);

	memset(cq->queue, 0, cq->memsize);



	if (user && ucontext->is_32b_cqe) {

		cq->qp_errp = &((struct t4_status_page *)

drivers/infiniband/hw/cxgb4/qp.c

+0 −1
Original line number Diff line number Diff line
@@ -274,7 +274,6 @@ static int create_qp(struct c4iw_rdev *rdev, struct t4_wq *wq, 
			 (unsigned long long)virt_to_phys(wq->sq.queue),

			 wq->rq.queue,

			 (unsigned long long)virt_to_phys(wq->rq.queue));

		memset(wq->rq.queue, 0, wq->rq.memsize);

		dma_unmap_addr_set(&wq->rq, mapping, wq->rq.dma_addr);

	}

drivers/infiniband/hw/hns/hns_roce_hw_v1.c

+0 −1
Original line number Diff line number Diff line
@@ -4265,7 +4265,6 @@ static int hns_roce_v1_create_eq(struct hns_roce_dev *hr_dev, 
		}



		eq->buf_list[i].map = tmp_dma_addr;

		memset(eq->buf_list[i].buf, 0, HNS_ROCE_BA_SIZE);

	}

	eq->cons_index = 0;

	roce_set_field(tmp, ROCEE_CAEP_AEQC_AEQE_SHIFT_CAEP_AEQC_STATE_M,

drivers/infiniband/hw/hns/hns_roce_hw_v2.c

+0 −3
Original line number Diff line number Diff line
@@ -1818,7 +1818,6 @@ static int hns_roce_init_link_table(struct hns_roce_dev *hr_dev, 
			goto err_alloc_buf_failed;



		link_tbl->pg_list[i].map = t;

		memset(link_tbl->pg_list[i].buf, 0, buf_chk_sz);



		entry[i].blk_ba0 = (t >> 12) & 0xffffffff;

		roce_set_field(entry[i].blk_ba1_nxt_ptr,
@@ -5467,8 +5466,6 @@ static int hns_roce_mhop_alloc_eq(struct hns_roce_dev *hr_dev, 
		eq->cur_eqe_ba = eq->l0_dma;

		eq->nxt_eqe_ba = 0;



		memset(eq->bt_l0, 0, eq->entries * eq->eqe_size);



		return 0;

	}