Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 4c2ba0c6 authored by Cristian Birsan's avatar Cristian Birsan Committed by Felipe Balbi
Browse files

usb: musb: fix DMA for host mode 



Commit ac33cdb1 ("usb: musb: Remove ifdefs for musb_host_rx in
musb_host.c part5") introduces a problem setting DMA host mode.

The musb_advance_schedule() is called immediately after receiving an
endpoint RX interrupt without waiting for the DMA transfer to complete.

As a consequence when the dma complete interrupt arrives the in_qh
member of hw_ep is already null an the musb_host_rx() exits on !urb
error case. Fix the done condition that advances the musb schedule.

Signed-off-by: default avatarCristian Birsan <cristian.birsan@microchip.com>
Signed-off-by: default avatarJoshua Henderson <joshua.henderson@microchip.com>
Tested-by: default avatarLadislav Michl <ladis@linux-mips.org>
Signed-off-by: default avatarFelipe Balbi <balbi@kernel.org>
parent 8de4b3a3

drivers/usb/musb/musb_host.c

+2 −4
Original line number Diff line number Diff line
@@ -2003,10 +2003,8 @@ void musb_host_rx(struct musb *musb, u8 epnum) 
				qh->offset,

				urb->transfer_buffer_length);



			done = musb_rx_dma_in_inventra_cppi41(c, hw_ep, qh,

							      urb, xfer_len,

							      iso_err);

			if (done)

			if (musb_rx_dma_in_inventra_cppi41(c, hw_ep, qh, urb,

							   xfer_len, iso_err))

				goto finish;

			else

				dev_err(musb->controller, "error: rx_dma failed\n");