Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 4b96b1a1 authored by Gautham R Shenoy's avatar Gautham R Shenoy Committed by Linus Torvalds
Browse files

[PATCH] Fix the spurious unlock_cpu_hotplug false warnings 

Cpu-hotplug locking has a minor race case caused because of setting the
variable "recursive" to NULL *after* releasing the cpu_bitmask_lock in the
function unlock_cpu_hotplug,instead of doing so before releasing the
cpu_bitmask_lock.

This was the cause of most of the recent false spurious lock_cpu_unlock
warnings.

This should fix the problem reported by Martin Lorenz reported in
http://lkml.org/lkml/2006/10/29/127

.

Thanks to Srinivasa DS for pointing it out.

Signed-off-by: default avatarGautham R Shenoy <ego@in.ibm.com>
Signed-off-by: default avatarAndrew Morton <akpm@osdl.org>
Signed-off-by: default avatarLinus Torvalds <torvalds@osdl.org>
parent d1ed6a3e

kernel/cpu.c

+1 −1
Original line number Diff line number Diff line
@@ -58,8 +58,8 @@ void unlock_cpu_hotplug(void) 
		recursive_depth--;

		return;

	}

	mutex_unlock(&cpu_bitmask_lock);

	recursive = NULL;

	mutex_unlock(&cpu_bitmask_lock);

}

EXPORT_SYMBOL_GPL(unlock_cpu_hotplug);