Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 4b6569e1 authored by Peter Griffin's avatar Peter Griffin Committed by Sasha Levin
Browse files

mfd: altera-sysmgr: Call of_node_put() only when of_parse_phandle() takes a ref 



[ Upstream commit e28c28a34ee9fa2ea671a20e5e7064e6220d55e7 ]

of_parse_phandle() returns a device_node with refcount incremented, which
the callee needs to call of_node_put() on when done. We should only call
of_node_put() when the property argument is provided though as otherwise
nothing has taken a reference on the node.

Fixes: f36e789a ("mfd: altera-sysmgr: Add SOCFPGA System Manager")
Signed-off-by: default avatarPeter Griffin <peter.griffin@linaro.org>
Link: https://lore.kernel.org/r/20240220115012.471689-4-peter.griffin@linaro.org


Signed-off-by: default avatarLee Jones <lee@kernel.org>
Signed-off-by: default avatarSasha Levin <sashal@kernel.org>
parent ac117067

drivers/mfd/altera-sysmgr.c

+3 −1
Original line number Diff line number Diff line
@@ -109,7 +109,9 @@ struct regmap *altr_sysmgr_regmap_lookup_by_phandle(struct device_node *np, 


	dev = driver_find_device_by_of_node(&altr_sysmgr_driver.driver,

					    (void *)sysmgr_np);

	if (property)

		of_node_put(sysmgr_np);



	if (!dev)

		return ERR_PTR(-EPROBE_DEFER);