Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 4ada295d authored by Bhaktipriya Shridhar's avatar Bhaktipriya Shridhar Committed by Greg Kroah-Hartman
Browse files

staging: rtl8188eu: os_dep: ioctl_linux: Clean up tests if NULL returned on failure 



Some functions like kmalloc/kzalloc return NULL on failure.
When NULL represents failure, !x is commonly used.

This was done using Coccinelle:

@@
expression *e;
identifier l1;
@@

e = \(kmalloc\|kzalloc\|kcalloc\|devm_kzalloc\)(...);
...
- e == NULL
+ !e

Signed-off-by: default avatarBhaktipriya Shridhar <bhaktipriya96@gmail.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 574502ca

drivers/staging/rtl8188eu/os_dep/ioctl_linux.c

+4 −4
Original line number Diff line number Diff line
@@ -2115,13 +2115,13 @@ static u8 set_pairwise_key(struct adapter *padapter, struct sta_info *psta) 
	u8 res = _SUCCESS;



	ph2c = kzalloc(sizeof(struct cmd_obj), GFP_KERNEL);

	if (ph2c == NULL) {

	if (!ph2c) {

		res = _FAIL;

		goto exit;

	}



	psetstakey_para = kzalloc(sizeof(struct set_stakey_parm), GFP_KERNEL);

	if (psetstakey_para == NULL) {

	if (!psetstakey_para) {

		kfree(ph2c);

		res = _FAIL;

		goto exit;
@@ -2153,12 +2153,12 @@ static int set_group_key(struct adapter *padapter, u8 *key, u8 alg, int keyid) 
	DBG_88E("%s\n", __func__);



	pcmd = kzalloc(sizeof(struct	cmd_obj), GFP_KERNEL);

	if (pcmd == NULL) {

	if (!pcmd) {

		res = _FAIL;

		goto exit;

	}

	psetkeyparm = kzalloc(sizeof(struct setkey_parm), GFP_KERNEL);

	if (psetkeyparm == NULL) {

	if (!psetkeyparm) {

		kfree(pcmd);

		res = _FAIL;

		goto exit;