Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 4a0a3c66 authored Mar 10, 2022 by Quinn Tran Committed by Greg Kroah-Hartman Apr 15, 2022

scsi: qla2xxx: Fix hang due to session stuck

commit c02aada06d19a215c8291bd968a99a270e96f734 upstream.

User experienced device lost. The log shows Get port data base command was
queued up, failed, and requeued again. Every time it is requeued, it set
the FCF_ASYNC_ACTIVE. This prevents any recovery code from occurring
because driver thinks a recovery is in progress for this session. In
essence, this session is hung.  The reason it gets into this place is the
session deletion got in front of this call due to link perturbation.

Break the requeue cycle and exit.  The session deletion code will trigger a
session relogin.

Link: https://lore.kernel.org/r/20220310092604.22950-8-njavali@marvell.com


Fixes: 726b8548 ("qla2xxx: Add framework for async fabric discovery")
Cc: stable@vger.kernel.org
Reviewed-by: Himanshu Madhani <himanshu.madhani@oracle.com>
Signed-off-by: Quinn Tran <qutran@marvell.com>
Signed-off-by: Nilesh Javali <njavali@marvell.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

parent 9d1651c8

drivers/scsi/qla2xxx/qla_def.h

+4 −0

Original line number	Diff line number	Diff line
		@@ -4870,4 +4870,8 @@ struct sff_8247_a0 {
		#include "qla_gbl.h"
		#include "qla_dbg.h"
		#include "qla_inline.h"

		#define IS_SESSION_DELETED(_fcport) (_fcport->disc_state == DSC_DELETE_PEND \|\| \
		_fcport->disc_state == DSC_DELETED)

		#endif

drivers/scsi/qla2xxx/qla_init.c

+17 −2

Original line number	Diff line number	Diff line
		@@ -572,6 +572,14 @@ qla2x00_async_adisc(struct scsi_qla_host vha, fc_port_t fcport,
		struct srb_iocb *lio;
		int rval = QLA_FUNCTION_FAILED;

		if (IS_SESSION_DELETED(fcport)) {
		ql_log(ql_log_warn, vha, 0xffff,
		"%s: %8phC is being delete - not sending command.\n",
		__func__, fcport->port_name);
		fcport->flags &= ~FCF_ASYNC_ACTIVE;
		return rval;
		}

		if (!vha->flags.online \|\| (fcport->flags & FCF_ASYNC_SENT))
		return rval;

		@@ -1314,8 +1322,15 @@ int qla24xx_async_gpdb(struct scsi_qla_host vha, fc_port_t fcport, u8 opt)
		struct port_database_24xx *pd;
		struct qla_hw_data *ha = vha->hw;

		if (!vha->flags.online \|\| (fcport->flags & FCF_ASYNC_SENT) \|\|
		fcport->loop_id == FC_NO_LOOP_ID) {
		if (IS_SESSION_DELETED(fcport)) {
		ql_log(ql_log_warn, vha, 0xffff,
		"%s: %8phC is being delete - not sending command.\n",
		__func__, fcport->port_name);
		fcport->flags &= ~FCF_ASYNC_ACTIVE;
		return rval;
		}

		if (!vha->flags.online \|\| fcport->flags & FCF_ASYNC_SENT) {
		ql_log(ql_log_warn, vha, 0xffff,
		"%s: %8phC online %d flags %x - not sending command.\n",
		__func__, fcport->port_name, vha->flags.online, fcport->flags);