Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 49fabf29 authored by Johan Hovold's avatar Johan Hovold Committed by Greg Kroah-Hartman
Browse files

USB: f81232: remove bogus call to wake up MSR queue 



Remove bogus call to wake up delta_msr_wait from process_read_urb where
the MSR status is never updated (only the LSR bits are masked out).

Comment that the wake-up call should made in f81232_update_line_status
when the MSR status changes.

Note that this driver is still mostly stubbed out.

Signed-off-by: default avatarJohan Hovold <jhovold@gmail.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 10c642d0

drivers/usb/serial/f81232.c

+7 −1
Original line number Diff line number Diff line
@@ -55,6 +55,13 @@ static void f81232_update_line_status(struct usb_serial_port *port, 
				      unsigned char *data,

				      unsigned int actual_length)

{

	/*

	 * FIXME: Call

	 *

	 *		wake_up_interruptible(&port->port.delta_msr_wait);

	 *

	 *	  on MSR changes.

	 */

}



static void f81232_read_int_callback(struct urb *urb)
@@ -110,7 +117,6 @@ static void f81232_process_read_urb(struct urb *urb) 
	line_status = priv->line_status;

	priv->line_status &= ~UART_STATE_TRANSIENT_MASK;

	spin_unlock_irqrestore(&priv->lock, flags);

	wake_up_interruptible(&port->port.delta_msr_wait);



	if (!urb->actual_length)

		return;