Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 49d61e23 authored by Eric Dumazet's avatar Eric Dumazet Committed by David S. Miller
Browse files

tunnels: missing rcu_assign_pointer() 



xfrm4_tunnel_register() & xfrm6_tunnel_register() should
use rcu_assign_pointer() to make sure previous writes
(to handler->next) are committed to memory before chain
insertion.

deregister functions dont need a particular barrier.

Signed-off-by: default avatarEric Dumazet <eric.dumazet@gmail.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent f39234d6

net/ipv4/tunnel4.c

+1 −1
Original line number Diff line number Diff line
@@ -39,7 +39,7 @@ int xfrm4_tunnel_register(struct xfrm_tunnel *handler, unsigned short family) 
	}



	handler->next = *pprev;

	*pprev = handler;

	rcu_assign_pointer(*pprev, handler);



	ret = 0;

net/ipv6/tunnel6.c

+1 −1
Original line number Diff line number Diff line
@@ -51,7 +51,7 @@ int xfrm6_tunnel_register(struct xfrm6_tunnel *handler, unsigned short family) 
	}



	handler->next = *pprev;

	*pprev = handler;

	rcu_assign_pointer(*pprev, handler);



	ret = 0;