Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 49925f24 authored by Gustavo A. R. Silva's avatar Gustavo A. R. Silva Committed by Kalle Valo
Browse files

wil6210: fix unsigned cid comparison with >= 0 



The comparison of cid >= 0 is always true because cid is of type u8
(8 bits, unsigned).

Fix this by removing such comparison and updating the type of
variable cid to u8 in the caller function.

Addresses-Coverity-ID: 1473079 ("Unsigned compared against 0")
Fixes: b9010f10 ("wil6210: add FT roam support for AP and station")
Signed-off-by: default avatarGustavo A. R. Silva <gustavo@embeddedor.com>
Signed-off-by: default avatarKalle Valo <kvalo@codeaurora.org>
parent 713358c3

drivers/net/wireless/ath/wil6210/wil6210.h

+1 −1
Original line number Diff line number Diff line
@@ -455,7 +455,7 @@ static inline void parse_cidxtid(u8 cidxtid, u8 *cid, u8 *tid) 
 */

static inline bool wil_cid_valid(u8 cid)

{

	return (cid >= 0 && cid < WIL6210_MAX_CID);

	return cid < WIL6210_MAX_CID;

}



struct wil6210_mbox_ring {

drivers/net/wireless/ath/wil6210/wmi.c

+1 −1
Original line number Diff line number Diff line
@@ -1177,7 +1177,7 @@ static void wmi_evt_ring_en(struct wil6210_vif *vif, int id, void *d, int len) 
	u8 vri = evt->ring_index;

	struct wireless_dev *wdev = vif_to_wdev(vif);

	struct wil_sta_info *sta;

	int cid;

	u8 cid;

	struct key_params params;



	wil_dbg_wmi(wil, "Enable vring %d MID %d\n", vri, vif->mid);