Commit 492140e4 authored Oct 21, 2021 by Oliver Neukum Committed by Greg Kroah-Hartman Nov 02, 2021

usbnet: sanity check for maxpacket



commit 397430b50a363d8b7bdda00522123f82df6adc5e upstream.

maxpacket of 0 makes no sense and oopses as we need to divide
by it. Give up.

V2: fixed typo in log and stylistic issues

Signed-off-by: Oliver Neukum <oneukum@suse.com>
Reported-by:  <syzbot+76bb1d34ffa0adc03baa@syzkaller.appspotmail.com>
Reviewed-by: Johan Hovold <johan@kernel.org>
Link: https://lore.kernel.org/r/20211021122944.21816-1-oneukum@suse.com


Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

parent 4ba6c163

drivers/net/usb/usbnet.c

+4 −0

Original line number	Diff line number	Diff line
		@@ -1773,6 +1773,10 @@ usbnet_probe (struct usb_interface udev, const struct usb_device_id prod)
		if (!dev->rx_urb_size)
		dev->rx_urb_size = dev->hard_mtu;
		dev->maxpacket = usb_maxpacket (dev->udev, dev->out, 1);
		if (dev->maxpacket == 0) {
		/* that is a broken device */
		goto out4;
		}

		/* let userspace know we have a random address */
		if (ether_addr_equal(net->dev_addr, node_id))