Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 48f34e10 authored by Daniel Vetter's avatar Daniel Vetter
Browse files

drm/i915/dvo: call ->mode_set callback only when the port is running 



The ns2501 controller seems to need the dpll and dvo port to accept
the timing update commands. Quick testing on my x30 here seems to
indicate that other dvo controllers don't mind. So let's move the
->mode_set callback to a place where we have the port up and running
already.

Tested-by: default avatarChris Wilson <chris@chris-wilson.co.uk>
Tested-by: default avatarThomas Richter <thor@math.tu-berlin.de>
Cc: stable@vger.kernel.org
Signed-off-by: default avatarDaniel Vetter <daniel.vetter@ffwll.ch>
parent 7f16e5c1

drivers/gpu/drm/i915/intel_dvo.c

+12 −4
Original line number Diff line number Diff line
@@ -173,11 +173,16 @@ static void intel_enable_dvo(struct intel_encoder *encoder) 
{

	struct drm_i915_private *dev_priv = encoder->base.dev->dev_private;

	struct intel_dvo *intel_dvo = enc_to_dvo(encoder);

	struct intel_crtc *crtc = to_intel_crtc(encoder->base.crtc);

	u32 dvo_reg = intel_dvo->dev.dvo_reg;

	u32 temp = I915_READ(dvo_reg);



	I915_WRITE(dvo_reg, temp | DVO_ENABLE);

	I915_READ(dvo_reg);

	intel_dvo->dev.dev_ops->mode_set(&intel_dvo->dev,

					 &crtc->config.requested_mode,

					 &crtc->config.adjusted_mode);



	intel_dvo->dev.dev_ops->dpms(&intel_dvo->dev, true);

}
@@ -186,6 +191,7 @@ static void intel_dvo_dpms(struct drm_connector *connector, int mode) 
{

	struct intel_dvo *intel_dvo = intel_attached_dvo(connector);

	struct drm_crtc *crtc;

	struct intel_crtc_config *config;



	/* dvo supports only 2 dpms states. */

	if (mode != DRM_MODE_DPMS_ON)
@@ -206,10 +212,16 @@ static void intel_dvo_dpms(struct drm_connector *connector, int mode) 
	/* We call connector dpms manually below in case pipe dpms doesn't

	 * change due to cloning. */

	if (mode == DRM_MODE_DPMS_ON) {

		config = &to_intel_crtc(crtc)->config;



		intel_dvo->base.connectors_active = true;



		intel_crtc_update_dpms(crtc);



		intel_dvo->dev.dev_ops->mode_set(&intel_dvo->dev,

						 &config->requested_mode,

						 &config->adjusted_mode);



		intel_dvo->dev.dev_ops->dpms(&intel_dvo->dev, true);

	} else {

		intel_dvo->dev.dev_ops->dpms(&intel_dvo->dev, false);
@@ -296,10 +308,6 @@ static void intel_dvo_mode_set(struct intel_encoder *encoder) 
		break;

	}



	intel_dvo->dev.dev_ops->mode_set(&intel_dvo->dev,

					 &crtc->config.requested_mode,

					 adjusted_mode);



	/* Save the data order, since I don't know what it should be set to. */

	dvo_val = I915_READ(dvo_reg) &

		  (DVO_PRESERVE_MASK | DVO_DATA_ORDER_GBRG);