Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 48eb5b9c authored by Daniel Borkmann's avatar Daniel Borkmann Committed by David S. Miller
Browse files

ixgbe: phy: fix uninitialized status in ixgbe_setup_phy_link_tnx 



Status variable is never initialized, can carry an arbitrary value
on the stack and thus may let the function fail.

Fixes: e90dd264 ("ixgbe: Make return values more direct")
Signed-off-by: default avatarDaniel Borkmann <dborkman@redhat.com>
Acked-by: default avatarEmil Tantilov <emil.s.tantilov@intel.com>
Signed-off-by: default avatarJeff Kirsher <jeffrey.t.kirsher@intel.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 79ce0477

drivers/net/ethernet/intel/ixgbe/ixgbe_phy.c

+1 −3
Original line number Diff line number Diff line
@@ -635,7 +635,6 @@ s32 ixgbe_check_phy_link_tnx(struct ixgbe_hw *hw, ixgbe_link_speed *speed, 
 **/

s32 ixgbe_setup_phy_link_tnx(struct ixgbe_hw *hw)

{

	s32 status;

	u16 autoneg_reg = IXGBE_MII_AUTONEG_REG;

	bool autoneg = false;

	ixgbe_link_speed speed;
@@ -700,8 +699,7 @@ s32 ixgbe_setup_phy_link_tnx(struct ixgbe_hw *hw) 


	hw->phy.ops.write_reg(hw, MDIO_CTRL1,

			      MDIO_MMD_AN, autoneg_reg);



	return status;

	return 0;

}



/**