Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 48e71241 authored by Elena Oat's avatar Elena Oat Committed by Greg Kroah-Hartman
Browse files

Staging: rtl8188eu: Fix warning of prefer ether_addr_copy(). 



This patch fixes the warning produced by checkpatch "Prefer
ether_addr_copy() over memcpy() if the Ethernet addresses are
__aligned(2)". The address that is copied is a field of
nat25_network_db_entry structure. Definition for this struct is found in
rtw_br_ext.h file. Pahole shows that the addresses are 2-byte aligned.

Signed-off-by: default avatarElena Oat <oat.elena@gmail.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 2c05f00f

drivers/staging/rtl8188eu/core/rtw_br_ext.c

+2 −2
Original line number Diff line number Diff line
@@ -409,7 +409,7 @@ static void __nat25_db_network_insert(struct adapter *priv, 
	db = priv->nethash[hash];

	while (db != NULL) {

		if (!memcmp(db->networkAddr, networkAddr, MAX_NETWORK_ADDR_LEN)) {

			memcpy(db->macAddr, macAddr, ETH_ALEN);

			ether_addr_copy(db->macAddr, macAddr);

			db->ageing_timer = jiffies;

			spin_unlock_bh(&priv->br_ext_lock);

			return;
@@ -422,7 +422,7 @@ static void __nat25_db_network_insert(struct adapter *priv, 
		return;

	}

	memcpy(db->networkAddr, networkAddr, MAX_NETWORK_ADDR_LEN);

	memcpy(db->macAddr, macAddr, ETH_ALEN);

	ether_addr_copy(db->macAddr, macAddr);

	atomic_set(&db->use_count, 1);

	db->ageing_timer = jiffies;