Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 48bb2931 authored by Linus Walleij's avatar Linus Walleij Committed by Greg Kroah-Hartman
Browse files

HID: cp2112: Use irqchip template 



[ Upstream commit 6bfa31756ae905e23050ee10a3b4d3d435122c97 ]

This makes the driver use the irqchip template to assign
properties to the gpio_irq_chip instead of using the
explicit calls to gpiochip_irqchip_add(). The irqchip is
instead added while adding the gpiochip.

Cc: Eudean Sun <eudean@arista.com>
Cc: Benjamin Tissoires <benjamin.tissoires@redhat.com>
Cc: Sébastien Szymanski <sebastien.szymanski@armadeus.com>
Signed-off-by: default avatarLinus Walleij <linus.walleij@linaro.org>
Signed-off-by: default avatarJiri Kosina <jkosina@suse.cz>
Stable-dep-of: e3c2d2d144c0 ("hid: cp2112: Fix duplicate workqueue initialization")
Signed-off-by: default avatarSasha Levin <sashal@kernel.org>
parent 7b62cf90

drivers/hid/hid-cp2112.c

+10 −9
Original line number Diff line number Diff line
@@ -1240,6 +1240,7 @@ static int cp2112_probe(struct hid_device *hdev, const struct hid_device_id *id) 
	struct cp2112_device *dev;

	u8 buf[3];

	struct cp2112_smbus_config_report config;

	struct gpio_irq_chip *girq;

	int ret;



	dev = devm_kzalloc(&hdev->dev, sizeof(*dev), GFP_KERNEL);
@@ -1343,6 +1344,15 @@ static int cp2112_probe(struct hid_device *hdev, const struct hid_device_id *id) 
	dev->gc.can_sleep		= 1;

	dev->gc.parent			= &hdev->dev;



	girq = &dev->gc.irq;

	girq->chip = &cp2112_gpio_irqchip;

	/* The event comes from the outside so no parent handler */

	girq->parent_handler = NULL;

	girq->num_parents = 0;

	girq->parents = NULL;

	girq->default_type = IRQ_TYPE_NONE;

	girq->handler = handle_simple_irq;



	ret = gpiochip_add_data(&dev->gc, dev);

	if (ret < 0) {

		hid_err(hdev, "error registering gpio chip\n");
@@ -1358,17 +1368,8 @@ static int cp2112_probe(struct hid_device *hdev, const struct hid_device_id *id) 
	chmod_sysfs_attrs(hdev);

	hid_hw_power(hdev, PM_HINT_NORMAL);



	ret = gpiochip_irqchip_add(&dev->gc, &cp2112_gpio_irqchip, 0,

				   handle_simple_irq, IRQ_TYPE_NONE);

	if (ret) {

		dev_err(dev->gc.parent, "failed to add IRQ chip\n");

		goto err_sysfs_remove;

	}



	return ret;



err_sysfs_remove:

	sysfs_remove_group(&hdev->dev.kobj, &cp2112_attr_group);

err_gpiochip_remove:

	gpiochip_remove(&dev->gc);

err_free_i2c: