Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 481a626a authored by Shiju Jose's avatar Shiju Jose Committed by David S. Miller
Browse files

net: hns3: add optimization in the hclge_hw_error_set_state 



1. This patch adds minor loop optimization in the
   hclge_hw_error_set_state function.
2. Adds logging module's name if it fails to configure the
   error interrupts.

Signed-off-by: default avatarShiju Jose <shiju.jose@huawei.com>
Signed-off-by: default avatarSalil Mehta <salil.mehta@huawei.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 381c356e

drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_err.c

+7 −9
Original line number Diff line number Diff line
@@ -586,18 +586,16 @@ static const struct hclge_hw_blk hw_blk[] = { 


int hclge_hw_error_set_state(struct hclge_dev *hdev, bool state)

{

	const struct hclge_hw_blk *module = hw_blk;

	int ret = 0;

	int i = 0;



	while (hw_blk[i].name) {

		if (!hw_blk[i].config_err_int) {

			i++;

			continue;

		}

		ret = hw_blk[i].config_err_int(hdev, state);

	while (module->name) {

		if (module->config_err_int) {

			ret = module->config_err_int(hdev, state);

			if (ret)

				return ret;

		i++;

		}

		module++;

	}



	return ret;