Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 478fa03b authored by Alexey Starikovskiy's avatar Alexey Starikovskiy Committed by Len Brown
Browse files

ACPI: EC: Don't parse DSDT for EC early init on Compal 

Compal DSDT breaks if scanned early, while we need early scan
for almost all ASUS machines. Safest workaround seems to be to
continue do an early scan for all machines, but this Compal model.

http://bugzilla.kernel.org/show_bug.cgi?id=14086



Signed-off-by: default avatarAlexey Starikovskiy <astarikovskiy@suse.de>
Signed-off-by: default avatarLen Brown <len.brown@intel.com>
parent 0adf3c74

drivers/acpi/ec.c

+15 −0
Original line number Diff line number Diff line
@@ -120,6 +120,7 @@ static struct acpi_ec { 


static int EC_FLAGS_MSI; /* Out-of-spec MSI controller */

static int EC_FLAGS_VALIDATE_ECDT; /* ASUStec ECDTs need to be validated */

static int EC_FLAGS_SKIP_DSDT_SCAN; /* Not all BIOS survive early DSDT scan */



/* --------------------------------------------------------------------------

                             Transaction Management
@@ -900,6 +901,13 @@ static const struct acpi_device_id ec_device_ids[] = { 
	{"", 0},

};



/* Some BIOS do not survive early DSDT scan, skip it */

static int ec_skip_dsdt_scan(const struct dmi_system_id *id)

{

	EC_FLAGS_SKIP_DSDT_SCAN = 1;

	return 0;

}



/* ASUStek often supplies us with broken ECDT, validate it */

static int ec_validate_ecdt(const struct dmi_system_id *id)

{
@@ -916,6 +924,10 @@ static int ec_flag_msi(const struct dmi_system_id *id) 
}



static struct dmi_system_id __initdata ec_dmi_table[] = {

	{

	ec_skip_dsdt_scan, "Compal JFL92", {

	DMI_MATCH(DMI_BIOS_VENDOR, "COMPAL"),

	DMI_MATCH(DMI_BOARD_NAME, "JFL92") }, NULL},

	{

	ec_flag_msi, "MSI hardware", {

	DMI_MATCH(DMI_BIOS_VENDOR, "Micro-Star"),
@@ -959,6 +971,9 @@ int __init acpi_ec_ecdt_probe(void) 
	/* fall through */

	}



	if (EC_FLAGS_SKIP_DSDT_SCAN)

		return -ENODEV;



	/* This workaround is needed only on some broken machines,

	 * which require early EC, but fail to provide ECDT */

	printk(KERN_DEBUG PREFIX "Look up EC in DSDT\n");